Adopt DispatchData in URLSessionHTTPClient#167
Open
guoye-zhang wants to merge 2 commits into
Open
Conversation
nakulbajaj
approved these changes
May 21, 2026
FranzBusch
reviewed
May 22, 2026
Member
FranzBusch
left a comment
FranzBusch
left a comment
There was a problem hiding this comment.
Do we really need to do this now? I think the better approach would probably be having DispatchData conform to RangeReplacableContainer and return that right away.
Collaborator
Author
|
I don't want to expose DispatchData out of the API. The reader could expose Span into DispatchData or bridge individual regions into Data, but DispatchData is an implementation detail. Regardless, this change removes one hidden copy (flattening) in the implementation, so I think it's still worth doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate Data flattening in URLSession backend by keeping DispatchData