[images]: resolve local tagged-digest reference instead of pulling#1963
Open
knQzx wants to merge 1 commit into
Open
[images]: resolve local tagged-digest reference instead of pulling#1963knQzx wants to merge 1 commit into
knQzx wants to merge 1 commit into
Conversation
A create/run with a `name:tag@sha256:...` (or `name@sha256:...`) reference missed the local image store: the reference parser gives the digest precedence and drops the tag, so the annotation-name lookup could not match a locally built image stored under its tag, and the reference was normalized to Docker Hub and pulled. Add a digest-based local lookup to ClientImage._search: when a reference carries a digest, resolve it against a locally stored image whose index descriptor digest matches before falling back to a remote pull. Fixes apple#1962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
a create/run using a
name:tag@sha256:...(orname@sha256:...) reference missed the local store: the reference parser gives the digest precedence and drops the tag, so the annotation-name lookup couldn't match a locally built image stored under its tag, and the reference was normalized to Docker Hub and pulledadd a digest-based local lookup in
ClientImage._search: when a reference carries a digest, resolve it against a locally stored image whose index descriptor digest matches before falling back to a pullfixes #1962
Type of Change
Testing
ClientImageSearchTests)