Resolve symlinked executable path when detecting install root#1415
Open
Ninja3047 wants to merge 1 commit intoapple:mainfrom
Open
Resolve symlinked executable path when detecting install root#1415Ninja3047 wants to merge 1 commit intoapple:mainfrom
Ninja3047 wants to merge 1 commit intoapple:mainfrom
Conversation
Ninja3047
force-pushed
the
resolve-symlink-install-root
branch
from
c7d1f50 to
c1a9514
Compare
Ninja3047
force-pushed
the
resolve-symlink-install-root
branch
from
c1a9514 to
e956e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This allows the container binary to be symlinked to alternative locations for packaging purposes, but still be able to resolve plugins properly. As a workaround, packagers can set
CONTAINER_INSTALL_ROOTto the actual install location but this seems more elegant.Testing