chore: remove unnecessary props from FeedbackButtton#1059
Open
junhongwang418 wants to merge 1 commit intomasterfrom
Open
chore: remove unnecessary props from FeedbackButtton#1059junhongwang418 wants to merge 1 commit intomasterfrom
junhongwang418 wants to merge 1 commit intomasterfrom
Conversation
✅ Deploy Preview for stately-chebakia-3a1e20 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Released prerelease version |
Contributor
|
This is a major breaking change. There are many usages of these props and removing them will require many changes in apm_bundle: https://cs.github.com/?scopeName=All+repos&scope=&q=repo%3Aappfolio%2Fapm_bundle+%3CFeedBackButton If you are willing to fix all the cases where these props are used, we can merge this. |
jmaher409
approved these changes
Oct 7, 2022
steventhan
force-pushed
the
master
branch
5 times, most recently
from
fc7b9c2 to
440bf24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recipient,cc, andfeatureare just passed to the callback ofonSubmit. Since we requireonSubmit, the client already has access torecipient,cc,feature.