Conversation
added 2 commits
July 15, 2016 14:51
find() is defined by Collection and may be defined by other subclasses. Calling node.find() directly avoids subclasses messing up load ensuring.
dtognazzini
force-pushed
the
fixExceptionContract
branch
from
3058ddb to
5a7a9ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 changes:
Capybara::ElementNotFoundunderAePageObjects::LoadingElementFailed.AePageObjects::LoadingElementFailedindicates that anAePageObjects::Elementfailed to load.Capybara::ElementNotFoundindicates that a Capybara element failed to be found. The Capybara exception should only be nested under the AePageObjects exception when the Capybara exception is the cause for an AePageObjects element failing to load.find()delegation in Node withnode.find(). In every case, Node wants to find the underlying Capybara element. Before this change, subclasses could define afindmethod and override the behavior in Node of finding the underlying Capybara node. For example,AePageObjects::Collectiondoes this today. Subclasses should be able to define methods without overriding this behavior.