ADFA-4551: Remove dead serialver tool and unused public-suffix data

[davidschachterADFA]

Summary

• Removes the vendored sun.tools.serialver.SerialVer tool and its resource bundles - confirmed no callers anywhere outside its own module (dead code carried over from OpenJDK).
• Excludes httpclient's bundled mozilla/public-suffix-list.txt (~240KB) - no code in this repo calls Apache HttpClient directly, so the cookie-domain data is pure dead weight pulled in transitively.

Part of ADFA-4551 (APK size reduction). A larger opportunity was found but not pursued here: jaxp/javac/doclint ship full ja and zh_CN locale variants of every diagnostic-message bundle (~800KB+ of the ticket's cited 1.67MB total). Excluding non-English locale properties could be a big win but needs confirmation the app never surfaces localized compiler diagnostics - flagging as a follow-up rather than bundling into this PR.

Test plan

• :app:assembleV8Debug builds successfully with these files removed/excluded

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3341ccb6-e00a-4af1-b1bb-755cd389ae54

📥 Commits

Reviewing files that changed from the base of the PR and between f4e0622 and a87ea95.

📒 Files selected for processing (5)

• app/build.gradle.kts
• composite-builds/build-deps/jdk-compiler/src/main/java/sun/tools/serialver/SerialVer.java
• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver.properties
• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver_ja.properties
• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver_zh_CN.properties

💤 Files with no reviewable changes (4)

• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver_zh_CN.properties
• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver.properties
• composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/serialver_ja.properties
• composite-builds/build-deps/jdk-compiler/src/main/java/sun/tools/serialver/SerialVer.java

---

📝 Walkthrough

• Removed the unused vendored sun.tools.serialver.SerialVer tool and its English, Japanese, and Chinese resource bundles.
• Excluded Apache HttpClient’s unused mozilla/public-suffix-list.txt from Android packaging to reduce APK size.
• :app:assembleV8Debug succeeds after these changes.
• Risk: future callers or indirect dependencies on SerialVer or the public-suffix list would need to restore the removed resources.

Walkthrough

Android packaging now excludes an unused public-suffix resource. The bundled serialver implementation and its English, Japanese, and Chinese resource bundles are removed from the JDK compiler build dependencies.

Changes

Build packaging and tool cleanup

Layer / File(s)	Summary
Android resource packaging app/build.gradle.kts	Adds mozilla/public-suffix-list.txt to the Android packaging exclusions with an explanatory comment.
Bundled serialver removal composite-builds/build-deps/jdk-compiler/src/main/java/sun/tools/serialver/SerialVer.java, composite-builds/build-deps/jdk-compiler/src/main/resources/sun/tools/serialver/resources/*	Removes the serialver command-line implementation and its localized resource bundles.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: hal-eisen-adfa

Poem

A bunny packs the build just right,
Hops past unused files out of sight.
Serialver rests beneath the hay,
While clean resources speed the way.
Squeak hooray! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: removing the dead serialver tool and unused public-suffix data.
Description check	✅ Passed	The description is clearly related to the changeset and matches the removals and APK size-reduction goal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ADFA-4551-strip-properties-comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[davidschachterADFA]

@claude review

[claude]

⚠️ Code review skipped — your organization's overage spend limit has been reached.

Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.

Once credits are available, comment @claude review on this pull request to trigger a review.