ADFA-4551: Remove dead/duplicate vector drawables#1570
Conversation
ic_launcher_animated(.xml/_dark.xml) and ic_launcher_main.xml have no references anywhere in the codebase (the splash screen uses ic_launcher_foreground, the launcher uses ic_launcher). The -night variant of cogo_brand_mark.xml is byte-for-byte identical to the base drawable, so removing it changes nothing visually - dark mode now just falls back to the base file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Warning Review limit reached
Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ic_androidide_log.xml carried 3+ decimal places throughout its path data on a 32-unit viewport rendered at 24dp - far finer than a pixel can represent. Rounded to 2 decimals, cutting the file by 13% with no visible difference. The other large vector drawables checked (androidide_header, ic_computer_vision, ic_launcher, etc.) already used <=2 decimals in their path data, so nothing to trim there. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pre-existing formatting debt (spaces instead of tabs, unwrapped license comment) surfaced once the file was touched by the precision trim, since Spotless's ratchet reformats any file that differs from origin/stage. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Added a second commit: trimmed path-coordinate precision in Needs a visual check on-device before merge - please confirm the log/notification icon still renders correctly (Logcat/build-log viewer icon). |
hal-eisen-adfa
left a comment
hal-eisen-adfa
left a comment
There was a problem hiding this comment.
My bad - didn't understand the fallback mechanism at first.
2 participants
Summary
ic_launcher_animated.xmlandic_launcher_animated_dark.xml- confirmed zero references anywhere in the codebase (splash screen usesic_launcher_foreground, launcher usesic_launcher).ic_launcher_main.xml- byte-for-byte duplicate ofic_launcher_fg_vector.xml, which is the one actually referenced (common/src/main/res/layout/layout_nav_header.xml).drawable-night/cogo_brand_mark.xml- byte-for-byte identical to the base drawable, so dark mode now just falls back to it with no visual change.Part of ADFA-4551 (APK size reduction: "optimize the SVG files in res/"). This PR covers only the zero-risk dedupe; reducing path-coordinate precision across the remaining ~278KB of vector drawables is a separate, riskier follow-up that needs on-device visual verification.
Test plan
:app:assembleV8Debugbuilds successfully