ADFA-4551: Remove unused bundled dependency files#1569
Conversation
Removes non-class resource files from three third-party jars that are never referenced by app code: commons-codec's Beider-Morse phonetic rule data, JLine console resources bundled in the Kotlin analysis-api jar, an IntelliJ K2-mode compatibility manifest, and unused bundled .proto well-known-type sources. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Nothing in the app calls into google-genai - it's dead weight on this branch (belongs to an in-progress, unmerged agent feature elsewhere). Also drops one of the three paths pulling commons-codec's phonetic data into the APK. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 Walkthrough
WalkthroughThe Android build excludes additional bundled resources, replaces the Google GenAI dependency with AndroidX lifecycle components, and removes the corresponding version catalog entries. ChangesAndroid build updates
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@claude review |
There was a problem hiding this comment.
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit at claude.ai/admin-settings/claude-code.
Once credits are available, comment @claude review on this pull request to trigger a review.
Please do these code reviews inside your Claude Code using the /code-review skill - not here in Github, thanks |
hal-eisen-adfa
left a comment
There was a problem hiding this comment.
FYI, the AI plugins that John is working on with add the google-genai back in though another path. Code On The Go size reduction will still be a benefit for folks who don't install those plugins.
Summary
.protowell-known-type sources.com.google.genaidependency entirely (also drops one of three paths pulling commons-codec's phonetic data into the APK).Investigated but intentionally left untouched:
openjdk/tools/- our own vendored javac, heavily used by the Java LSP.play-services-*- real transitive dependency of Firebase Analytics, which is actively used.Part of ADFA-4551 (APK size reduction), split into separate PRs per sub-concern.
Test plan
:app:assembleV8Debugbuilds successfully with these excludes/removal applied