Skip to content

fix: Update click-elements.ts - fix uncaught exception issue #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gilc83 wants to merge 6 commits into
base: master
Choose a base branch
from
+24 −12
Open

fix: Update click-elements.ts - fix uncaught exception issue #2794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5397354
Update click-elements.ts
Gilc83 Jan 6, 2025
14024a1
Merge branch 'apify:master' into patch-1
Gilc83 Mar 26, 2025
9a8c84c
Merge branch 'apify:master' into patch-1
Gilc83 Sep 8, 2025
9e6965d
Update click-elements.ts
Gilc83 Sep 8, 2025
ac126d9
Add try-catch to isTopFrameNavigationRequest
Gilc83 Sep 8, 2025
477a28f
Format code
janbuchar Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/playwright-crawler/src/internals/enqueue-links/click-elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,12 @@ function createTargetCreatedHandler(requests: Set<string>): (popup: Page) => Pro
* @ignore
*/
function isTopFrameNavigationRequest(page: Page, req: Request): boolean {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
try {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
} catch (error) {
log.error('Error in isTopFrameNavigationRequest', { error });
return false;
}
}

/**
Expand Down Expand Up @@ -567,11 +572,12 @@ async function waitForPageIdle({
*/
async function restoreHistoryNavigationAndSaveCapturedUrls(page: Page, requests: Set<string>): Promise<void> {
/* istanbul ignore next */
const state = await page.evaluate(() => {
const { stateHistory } = window.history as unknown as ApifyWindow;
(window as unknown as Dictionary).history = (window as unknown as Dictionary).__originalHistory__;
return stateHistory;
});
const state =
(await page.evaluate(() => {
const { stateHistory } = window.history as unknown as ApifyWindow;
(window as unknown as Dictionary).history = (window as unknown as Dictionary).__originalHistory__;
return stateHistory;
})) ?? [];

state.forEach((args) => {
try {
Expand Down
18 changes: 12 additions & 6 deletions packages/puppeteer-crawler/src/internals/enqueue-links/click-elements.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,12 @@ function createInterceptRequestHandler(page: Page, requests: Set<string>): (req:
* @ignore
*/
function isTopFrameNavigationRequest(page: Page, req: PuppeteerRequest): boolean {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
try {
return req.isNavigationRequest() && req.frame() === page.mainFrame();
} catch (error) {
log.error('Error in isTopFrameNavigationRequest', { error });
return false;
}
}

/**
Expand Down Expand Up @@ -583,11 +588,12 @@ async function waitForPageIdle({
*/
async function restoreHistoryNavigationAndSaveCapturedUrls(page: Page, requests: Set<string>): Promise<void> {
/* istanbul ignore next */
const state = await page.evaluate(() => {
const { stateHistory } = window.history as unknown as ApifyWindow;
(window as unknown as Dictionary).history = (window as unknown as Dictionary).__originalHistory__;
return stateHistory;
});
const state =
(await page.evaluate(() => {
const { stateHistory } = window.history as unknown as ApifyWindow;
(window as unknown as Dictionary).history = (window as unknown as Dictionary).__originalHistory__;
return stateHistory;
})) ?? [];
state.forEach((args) => {
try {
const stateUrl = args[args.length - 1] as string;
Expand Down
Loading