Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/list-unnamed-child-runs #1250 +/- ##
===============================================================
- Coverage 93.95% 93.92% -0.03%
===============================================================
Files 54 54
Lines 3836 3834 -2
===============================================================
- Hits 3604 3601 -3
- Misses 232 233 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
force-pushed
the
fix/abort-unnamed-child-runs
branch
from
November 12, 2026 11:51
862df5a to
2b565c4
Compare
abort_with_parent for unnamed child runsabort_with_parent handling of child runs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
abort_with_parentworks for child runs started without arun_name. Until now it raised aValueError.abort_with_parentkeeps the recorded value.abort_with_parentfor child runs without a nameABORTINGeach marked run gets one graceful abort request, like the named ones.Recorded value
abort_with_parentnow defaults toNone.TrueorFalsereplaces the recorded value.Nonekeeps it, and a new run is not aborted with the parent.FAILEDor missing one keeps the recorded value when the call does not set it.Calls while the parent is being aborted
abort_with_parent=True, or when the call does not set it and the record has it.RuntimeErrorand does not start, resurrect or reattach anything.SUCCEEDEDis still returned, since nothing starts.abort_with_parentused to resurrect a child that the SDK had just aborted with the parent. It now raises the sameRuntimeError.Stacked on #1249: it targets
fix/list-unnamed-child-runsand moves tomasteronce #1249 merges. Split out of #1154.✍️ Drafted by Claude Code