Skip to content

fix: do not abort Actor exit when the terminal status message fails - #1078

Open
vdusek wants to merge 2 commits into
masterfrom
worktree-fix-b11
Open

fix: do not abort Actor exit when the terminal status message fails#1078
vdusek wants to merge 2 commits into
masterfrom
worktree-fix-b11

Conversation

@vdusek

@vdusek vdusek commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

In _ActorType.__aexit__, the terminal set_status_message() call was the only step in finalize() not wrapped in try/except Exception. A transient API error there propagated out of __aexit__ and skipped everything after it: the event manager exit, the charging manager exit, _save_actor_state() and sys.exit(self.exit_code). The run then died with an unrelated traceback, the wrong exit code, and unpersisted state.

The call is now guarded the same way as the three steps that follow it - the failure is logged and cleanup continues.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Aug 4, 2026
@vdusek vdusek self-assigned this Aug 4, 2026
@github-actions github-actions Bot added this to the 146th sprint - Tooling team milestone Aug 4, 2026
@github-actions github-actions Bot added the tested Temporary label used only programatically for some analytics. label Aug 4, 2026
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (cad8d7e) to head (ab492b4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
+ Coverage   91.83%   91.93%   +0.10%     
==========================================
  Files          51       51              
  Lines        3235     3238       +3     
==========================================
+ Hits         2971     2977       +6     
+ Misses        264      261       -3     
Flag Coverage Δ
e2e 35.26% <0.00%> (-0.04%) ⬇️
integration 57.01% <0.00%> (-0.03%) ⬇️
unit 83.29% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review August 4, 2026 12:51
@vdusek
vdusek requested a review from Mantisus August 4, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants