fix: do not abort Actor exit when the terminal status message fails - #1078
Open
vdusek wants to merge 2 commits into
Open
fix: do not abort Actor exit when the terminal status message fails#1078vdusek wants to merge 2 commits into
vdusek wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 91.83% 91.93% +0.10%
==========================================
Files 51 51
Lines 3235 3238 +3
==========================================
+ Hits 2971 2977 +6
+ Misses 264 261 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 4, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_ActorType.__aexit__, the terminalset_status_message()call was the only step infinalize()not wrapped intry/except Exception. A transient API error there propagated out of__aexit__and skipped everything after it: the event manager exit, the charging manager exit,_save_actor_state()andsys.exit(self.exit_code). The run then died with an unrelated traceback, the wrong exit code, and unpersisted state.The call is now guarded the same way as the three steps that follow it - the failure is logged and cleanup continues.
✍️ Drafted by Claude Code