feat: scenarios as YAML, suite profiles, sync tool - #10
Open
RobertCrupa wants to merge 4 commits into
Open
RobertCrupa wants to merge 4 commits into
RobertCrupa wants to merge 4 commits into
Conversation
RobertCrupa
added this pull request to stack #12
September 21, 2026 13:26
Scenario source of truth moves to scenarios/<suite>/<owner>/<subject>.yaml with per-item checks, judge-facing expectedOutput and item titles. Suite profiles (profiles/*.yaml) declare what each suite tests, tools per skill, and fix areas. tools/ syncs scenarios to Langfuse and validates them. Builds on feat/workflow-runner-core.
…hing loadSuite recorded "prompt is empty" / "expected is empty" and then kept going, so the next line dereferenced the missing field and a single bad scenario file killed validation and sync for the whole suite.
The per-scenario timeoutSecs is documented in scenarios/README.md and written into dataset-item metadata, but the session killer only ever used the Actor-level perItemTimeoutSecs, so the override was silently ignored.
The usage scenario says it tests comprehension of the required booleans, but apify.input + required[] only checks that a key is present, so an agent submitting forRent: true, sold: true still passed. Add equals assertions for the four flags and cover the value semantics in the contract checks tests.
RobertCrupa
force-pushed
the
feat/scenario-suites
branch
from
September 21, 2026 13:30
f7c371d to
d03110f
Compare
artogahr
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves scenario source of truth to `scenarios///.yaml` with per-item checks, judge-facing `expectedOutput`, and item titles. Adds suite profiles (`profiles/*.yaml`) declaring what each suite tests, tools per skill, and fix areas. Adds `tools/` to sync scenarios to Langfuse and validate them.
Depends on the runner core from #9.
🤖 Generated with Claude Code