fix: add missing response codes and fix schema issues in actor-builds endpoints#2287
Draft
fix: add missing response codes and fix schema issues in actor-builds endpoints#2287
Conversation
|
Preview for this PR was built for commit |
|
Preview for this PR was built for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes OpenAPI specification validation errors detected at runtime for the
/v2/actor-buildsendpoints.Validation errors being fixed
These are the exact lines from the error log:
Changes
New file:
components/responses/Forbidden.yamlAdded a shared
403 Forbiddenresponse component, following the same pattern as the existingUnauthorized.yamlandNotFound.yamlcomponents. Reused across all endpoints in this PR that can return 403.paths/actor-builds/actor-builds.yaml-GET /v2/actor-builds403response - returned when the caller lacks permission to list builds.paths/actor-builds/actor-builds@{buildId}.yaml-GETandDELETE /v2/actor-builds/{buildId}401response - returned when no valid token is provided.404response - returned when the build ID does not exist.404response - returned when the build ID does not exist.paths/actor-builds/actor-builds@{buildId}@abort.yaml-POST /v2/actor-builds/{buildId}/abort401response - returned when no valid token is provided.403response - returned when the caller does not own the build.paths/actor-builds/actor-builds@{buildId}@log.yaml-GET /v2/actor-builds/{buildId}/logstreamquery parameter fromrequired: truetorequired: false- it is an optional modifier, not required on every request.downloadquery parameter fromrequired: truetorequired: false- same reason.404response - returned when the build ID does not exist.paths/actor-builds/actor-builds@{buildId}@openapi.json.yaml-GET /v2/actor-builds/{buildId}/openapi.json404response - returned when the build ID does not exist.Issues
Partially implements: #2286
🤖 Generated with Claude Code