Skip to content

fix(nginx): use map directive for trailing slash redirect #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
B4nan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(nginx): use map directive for trailing slash redirect #2227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions nginx.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ map $request_uri $has_no_extension {
default 0;
}

# Detect trailing slash (except root /) and capture path without it
map $request_uri $trailing_slash_uri {
~^(.+)/(\?.*)?$ $1$2;
default "";
}

server {
listen 0.0.0.0:8080;
server_name docs.apify.com docs.apify.loc;
Expand All @@ -21,6 +27,11 @@ server {
set $backend "https://apify.github.io/apify-docs";
resolver 1.1.1.1 8.8.8.8 valid=30s ipv6=off;

# redirect trailing slashes (except root /) - processed before location matching
if ($trailing_slash_uri) {
return 301 $trailing_slash_uri;
}

location = / {
if ($serve_markdown) {
rewrite ^ /llms.txt last;
Expand All @@ -34,12 +45,6 @@ server {
proxy_pass $backend$uri;
}

# remove trailing slashes from all URLs (except root /)
# exact match locations (e.g., location = /sdk/js/) take priority over this regex
location ~ ^(.+)/$ {
rewrite ^(.+)/$ $1$is_args$args? redirect;
}

location / {
set $rewrite_condition "$serve_markdown$has_no_extension";
set $proxy_path $request_uri;
Expand Down