Skip to content

fix: resolve fast-xml-parser, lodash security vulnerabilities#2214

Open
B4nan wants to merge 1 commit intomasterfrom
fix/security-fast-xml-parser
Open

fix: resolve fast-xml-parser, lodash security vulnerabilities#2214
B4nan wants to merge 1 commit intomasterfrom
fix/security-fast-xml-parser

Conversation

@B4nan
Copy link
Member

@B4nan B4nan commented Feb 2, 2026

Summary

Test plan

  • npm audit shows 0 vulnerabilities
  • CI passes

🤖 Generated with Claude Code


Note

Medium Risk
Forces upgraded transitive dependencies (including fast-xml-parser 4→5) via npm overrides, which could introduce subtle runtime/build incompatibilities despite being security-driven.

Overview
Pins security-patched dependency versions via package.json overrides, forcing fast-xml-parser@5.3.4, lodash@4.17.23, and lodash-es@4.17.23.

Updates package-lock.json to reflect the forced resolutions (including strnum bump and removal of redundant nested lodash-es entries) and bumps the workspace @apify/docs-theme from 1.0.230 to 1.0.231.

Written by Cursor Bugbot for commit de32548. Configure here.

@github-actions github-actions bot added this to the 133rd sprint - Tooling team milestone Feb 2, 2026
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 2, 2026
@B4nan B4nan added the adhoc Ad-hoc unplanned task added during the sprint. label Feb 2, 2026
@apify-service-account
Copy link

Preview for this PR was built for commit de32548 and is ready at https://pr-2214.preview.docs.apify.com!

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment @cursor review or bugbot run to trigger another review on this PR

package.json Outdated
"js-yaml": "4.1.1"
}
},
"fast-xml-parser": "5.3.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version override may break dependent packages

Medium Severity

The npm override forces fast-xml-parser from version 4.5.3 to 5.3.4, which is a major version upgrade. The openapi-sampler package explicitly declares a dependency on "fast-xml-parser": "^4.5.0" (accepting versions >=4.5.0 <5.0.0), meaning it was designed against the v4 API. Major version upgrades typically contain breaking changes, and forcing v5 via override could cause runtime compatibility issues for packages expecting v4. The PR checklist shows CI has not yet passed.

Fix in Cursor Fix in Web

Add npm override for fast-xml-parser to version 5.3.4 to fix
high-severity vulnerability (GHSA-37qj-frw5-hhjh). Override is
required because openapi-sampler specifies ^4.5.0 which doesn't
include the 5.x fix.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@B4nan B4nan force-pushed the fix/security-fast-xml-parser branch from de32548 to f6fba91 Compare February 2, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants