refactor: Replace kwargs.pop with explicit resource_path keyword arguments#648
Open
refactor: Replace kwargs.pop with explicit resource_path keyword arguments#648
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
adhoc
LogClient is a sub-resource client (e.g. /actor-runs/{id}/log) that
does not receive its own resource_id from callers.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
DatasetClient, KeyValueStoreClient, and RequestQueueClient are also
used as sub-resources of runs (e.g. /actor-runs/{id}/dataset) where
no resource_id is passed by callers.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 96.62% 96.67% +0.04%
==========================================
Files 45 47 +2
Lines 4271 4965 +694
==========================================
+ Hits 4127 4800 +673
- Misses 144 165 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
reviewed
Feb 26, 2026
vdusek
force-pushed
the
refactor/resolve-resource-path-kwargs-pop
branch
from
53abed9 to
e204bed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kwargs.pop('resource_path', ...)anti-pattern with proper keyword arguments in all resource client__init__methods.UserClient(resource_id: str | None = None, resolved to'me') andRequestQueueClient(retains extraclient_keyparam).Test plan
🤖 Generated with Claude Code