Repository navigation
fix(Raw): local_timestamp_kind is gone from the raw files - #24
Closed
almostintuitive wants to merge 2 commits into
Closed
almostintuitive wants to merge 2 commits into
almostintuitive wants to merge 2 commits into
Conversation
…om the raw files The served raw files no longer have the local_timestamp_kind column, and funding_rate no longer has next_funding_time. Fix the dataset description the CLI prints and the README, which now says where measured vs modelled local times are recorded (file metadata). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…te description Only local_timestamp_kind is gone from the raw files. next_funding_timestamp stays a served column of funding_rate files (being restored in production), so the dataset description and README table row go back to what main has. The local_timestamp_kind paragraph change stays. The previous commit message claimed next_funding_timestamp was removed too. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
almostintuitive
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
aperiodic-io/queries-historical#422removedlocal_timestamp_kind(every raw file) from the raw buckets, and it stays removed.next_funding_timestamp(a column offunding_ratefiles) is NOT removed: it stays a served column and is being restored in the production buckets (footer rewrite, in progress). An earlier version of this PR, its title and its first commit message said both columns were gone; that was wrong. The CLI only downloads the files as served, so nothing functional changes; the text does.Changes
README.md: the paragraph that said every file starts withlocal_timestamp_kindnow sayslocal_timestampis measured where we capture the feed and modelled earlier, with no per-row marker: each Parquet file records which in its metadata (aperiodic.origin,aperiodic.latency_model).cli_raw.goand the README table row:funding_ratekeeps its description "Funding rate and next funding time", identical tomain. (An earlier commit in this PR shortened it; the latest commit reverts that.) The net diff againstmainis the README paragraph only.For a short while, until the production restore finishes, the
funding_ratefiles may still lacknext_funding_timestamp; the description states the intended state.Tested
gofmtclean;go vetclean.go test ./...: 6 tests fail, all live tests that needAPERIODIC_API_KEY(not set here); they fail identically onmain. No test asserts on the columns.🤖 Generated with Claude Code