ZOOKEEPER-4947: Close clients after authentication failure - #2443
Open
1fanwang wants to merge 1 commit into
Open
ZOOKEEPER-4947: Close clients after authentication failure#24431fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
ZooKeeper.close() treated AUTH_FAILED clients as already closed and skipped prompt shutdown of their connection threads. Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client that fails SASL authentication stays in
AUTH_FAILEDwhen the caller closes it. The close guard treats every non-alive state as already closed, so it skips the connection shutdown and leaves the client threads running.This narrows the early return to
CLOSED. Authentication failures now use the normal disconnect path, while repeated close calls remain idempotent.Related:
Testing