ZOOKEEPER-5038 Decouple HTTP admin server into a separate module.#2395
Open
txangel wants to merge 1 commit into
Open
ZOOKEEPER-5038 Decouple HTTP admin server into a separate module.#2395txangel wants to merge 1 commit into
txangel wants to merge 1 commit into
Conversation
txangel
force-pushed
the
ZOOKEEPER-5038-decouple-admin-server
branch
2 times, most recently
from
317ea0b to
d512ade
Compare
Author
|
@anmolnar I was following the suggestion of @lhotari in https://issues.apache.org/jira/browse/ZOOKEEPER-5038 |
Extract JettyAdminServer into a new zookeeper-http-admin module that targets Java 17 and Jetty 12 (EE8). This decouples the Jetty upgrade from the ZooKeeper Java baseline, allowing the rest of ZooKeeper to remain on Java 8/11. The existing reflection-based loading in AdminServerFactory means zookeeper-server requires no interface changes. On Java 8/11, the admin server gracefully falls back to DummyAdminServer with a clear warning about the Java 17 requirement. Breaking change: the HTTP admin server now requires Java 17+.
txangel
force-pushed
the
ZOOKEEPER-5038-decouple-admin-server
branch
from
d512ade to
28c9be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract JettyAdminServer into a new zookeeper-http-admin module that targets Java 17 and Jetty 12 (EE8).
This decouples the Jetty upgrade from the ZooKeeper Java baseline, allowing the rest of ZooKeeper to remain on Java 8/11.
The existing reflection-based loading in AdminServerFactory means zookeeper-server requires no interface changes.
On Java 8/11, the admin server falls back to DummyAdminServer with a clear warning in the logs about the Java 17 requirement.
Breaking change: the HTTP admin server, and only the admin server, now requires Java 17+.