Skip to content

[ZEPPELIN-6534] Escape note name before building clone-name RegExp #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kimyenac wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

[ZEPPELIN-6534] Escape note name before building clone-name RegExp #5318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a82362
[ZEPPELIN-6534] Escape note name before building clone-name RegExp
kimyenac Jul 18, 2026
6e0448c
[ZEPPELIN-6534] Guard onParagraphSearch against uninitialized ViewChi…
kimyenac Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zeppelin-web-angular/src/app/pages/workspace/notebook/notebook.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export class NotebookComponent extends MessageListenersManager implements OnInit
}

onParagraphSearch(term: string) {
this.listOfNotebookParagraphComponent.forEach(comp => comp.highlightMatches(term || ''));
this.listOfNotebookParagraphComponent?.forEach(comp => comp.highlightMatches(term || ''));
}

saveParagraph(id: string) {
Expand Down
3 changes: 2 additions & 1 deletion zeppelin-web-angular/src/app/share/note-create/note-create.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ export class NoteCreateComponent extends MessageListenersManager implements OnIn
const lastIndex = cloneNote.name.lastIndexOf(' ');
const endsWithNumber = !!cloneNote.name.match('^.+?\\s\\d$');
const noteNamePrefix = endsWithNumber ? cloneNote.name.slice(0, lastIndex) : cloneNote.name;
const regexp = new RegExp(`^${noteNamePrefix}.+`);
const escapedNoteNamePrefix = noteNamePrefix.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
const regexp = new RegExp(`^${escapedNoteNamePrefix}.+`);

this.noteListService.notes.flatList.forEach(note => {
const noteName = note.path;
Expand Down
Loading