Skip to content

[ZEPPELIN-6544] Harden keyboard-shortcut e2e helpers against silent passes#5315

Open
voidmatcha wants to merge 1 commit into
apache:masterfrom
voidmatcha:fix/harden-keyboard-e2e-helpers
Open

[ZEPPELIN-6544] Harden keyboard-shortcut e2e helpers against silent passes#5315
voidmatcha wants to merge 1 commit into
apache:masterfrom
voidmatcha:fix/harden-keyboard-e2e-helpers

Conversation

@voidmatcha

@voidmatcha voidmatcha commented Jul 17, 2026

Copy link
Copy Markdown
Member

What is this PR for?

Follow-up to ZEPPELIN-6536 (#5304). A cross-review of the merged keyboard-shortcut suite found four silent-pass risks in the helpers; this PR closes them:

  • pressShortcutFromHostUntil now polls for the press's effect before retrying, so a slow toggle is not double-pressed and the loop cannot return on the transient state between two in-flight effects.
  • The clear-output test asserts the result is visible before pressing; previously a no-output run let the helper skip the press entirely.
  • InsertAbove/InsertBelow emptiness assertions now gate on the editor being rendered (waitForEditorRendered); an unrendered editor reads as '' and matched vacuously.
  • setCodeEditorContent compares normalized equality instead of containment, so stale fixture text fails at seeding time.

Test-only change; no product code touched.

What type of PR is it?

Improvement

What is the Jira issue?

ZEPPELIN-6544

How should this be tested?

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@voidmatcha
voidmatcha force-pushed the fix/harden-keyboard-e2e-helpers branch 12 times, most recently from 8febcb3 to 880122a Compare July 18, 2026 04:46
@voidmatcha
voidmatcha force-pushed the fix/harden-keyboard-e2e-helpers branch from 880122a to dca38e4 Compare July 18, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant