[ZEPPELIN-6544] Harden keyboard-shortcut e2e helpers against silent passes#5315
Open
voidmatcha wants to merge 1 commit into
Open
[ZEPPELIN-6544] Harden keyboard-shortcut e2e helpers against silent passes#5315voidmatcha wants to merge 1 commit into
voidmatcha wants to merge 1 commit into
Conversation
voidmatcha
force-pushed
the
fix/harden-keyboard-e2e-helpers
branch
12 times, most recently
from
July 18, 2026 04:46
8febcb3 to
880122a
Compare
voidmatcha
force-pushed
the
fix/harden-keyboard-e2e-helpers
branch
from
July 18, 2026 06:18
880122a to
dca38e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Follow-up to ZEPPELIN-6536 (#5304). A cross-review of the merged keyboard-shortcut suite found four silent-pass risks in the helpers; this PR closes them:
pressShortcutFromHostUntilnow polls for the press's effect before retrying, so a slow toggle is not double-pressed and the loop cannot return on the transient state between two in-flight effects.waitForEditorRendered); an unrendered editor reads as''and matched vacuously.setCodeEditorContentcompares normalized equality instead of containment, so stale fixture text fails at seeding time.Test-only change; no product code touched.
What type of PR is it?
Improvement
What is the Jira issue?
ZEPPELIN-6544
How should this be tested?
Questions: