Skip to content

[ZEPPELIN-6542] Fix missing "Run" menu for first paragraph in Zeppelin#5307

Open
kevinjmh wants to merge 1 commit into
apache:masterfrom
kevinjmh:patch-3
Open

[ZEPPELIN-6542] Fix missing "Run" menu for first paragraph in Zeppelin#5307
kevinjmh wants to merge 1 commit into
apache:masterfrom
kevinjmh:patch-3

Conversation

@kevinjmh

@kevinjmh kevinjmh commented Jul 16, 2026

Copy link
Copy Markdown
Member

What is this PR for?

The "Run" menu item for the first paragraph was not showing due to an incorrect show condition (!this.first). This change sets show: true unconditionally for the "Run" button, ensuring it is always visible for the first paragraph — which is expected behavior in Zeppelin.

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-6542

How should this be tested?

  • Strongly recommended: add automated unit tests for any new or changed behavior
  • Outline any manual steps to test the PR here.

Screenshots (if appropriate)

Questions:

  • Does the license files need to update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

@ParkGyeongTae ParkGyeongTae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix — the code change itself (show: !this.first → show: true for the Run menu item) looks correct and low-risk.

I'm marking this as Request changes not because of the code, but because the PR doesn't link to a Jira issue — the title has no [ZEPPELIN-XXXX] prefix, and the "What is the Jira issue?" section in the description is still the unfilled template placeholder. Per the Zeppelin contribution guidelines, every PR should reference a Jira issue in the title for traceability.

Could you either:

  1. Link this to an existing relevant Jira issue and update the PR title accordingly, or
  2. Open a new Jira issue (e.g. "Fix missing Run menu for first paragraph") and reference it as [ZEPPELIN-XXXX] in the title

Happy to approve once that's in place.

@kevinjmh kevinjmh changed the title [MINOR] Fix missing "Run" menu for first paragraph in Zeppelin [ZEPPELIN-6542] Fix missing "Run" menu for first paragraph in Zeppelin Jul 17, 2026
@kevinjmh

Copy link
Copy Markdown
Member Author

@ParkGyeongTae Jira added

@ParkGyeongTae ParkGyeongTae left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title now includes [ZEPPELIN-6542] — thanks for adding the Jira reference.
LGTM, +1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants