[ZEPPELIN-6542] Fix missing "Run" menu for first paragraph in Zeppelin#5307
Open
kevinjmh wants to merge 1 commit into
Open
[ZEPPELIN-6542] Fix missing "Run" menu for first paragraph in Zeppelin#5307kevinjmh wants to merge 1 commit into
kevinjmh wants to merge 1 commit into
Conversation
ParkGyeongTae
requested changes
Jul 16, 2026
ParkGyeongTae
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix — the code change itself (show: !this.first → show: true for the Run menu item) looks correct and low-risk.
I'm marking this as Request changes not because of the code, but because the PR doesn't link to a Jira issue — the title has no [ZEPPELIN-XXXX] prefix, and the "What is the Jira issue?" section in the description is still the unfilled template placeholder. Per the Zeppelin contribution guidelines, every PR should reference a Jira issue in the title for traceability.
Could you either:
- Link this to an existing relevant Jira issue and update the PR title accordingly, or
- Open a new Jira issue (e.g. "Fix missing Run menu for first paragraph") and reference it as [ZEPPELIN-XXXX] in the title
Happy to approve once that's in place.
Member
Author
|
@ParkGyeongTae Jira added |
ParkGyeongTae
approved these changes
Jul 18, 2026
Member
There was a problem hiding this comment.
Title now includes [ZEPPELIN-6542] — thanks for adding the Jira reference.
LGTM, +1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The "Run" menu item for the first paragraph was not showing due to an incorrect show condition (!this.first). This change sets show: true unconditionally for the "Run" button, ensuring it is always visible for the first paragraph — which is expected behavior in Zeppelin.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6542
How should this be tested?
Screenshots (if appropriate)
Questions: