Repository navigation
Conversation
|
Review required. |
| Null) | ||
|
|
||
| val angularObject = addAngularObject(functionName, 0) | ||
| val angularObject = addAngularObject(functionName, Int.box(0)) |
There was a problem hiding this comment.
This is the only place where I am not sure that this is completely correct.
| */ | ||
| @ZeppelinApi | ||
| def model(name: String, value: Any): AbstractAngularElem = { | ||
| def model(name: String, value: AnyRef): AbstractAngularElem = { |
There was a problem hiding this comment.
AnyRef is the same as object.
https://docs.scala-lang.org/tour/unified-types.html#scala-type-hierarchy
|
Review required. |
1deca4a to
b21c947
Compare
|
Review required. |
|
This pull request has been inactive for over a year. If no further activity occurs within the next 30 days, it will be automatically closed. If you believe this PR is still relevant, please feel free to leave a comment or make an update. Thank you! |
|
This pull request has been automatically closed due to prolonged inactivity (over one year without updates). If you feel this was done in error or would like to continue the discussion, feel free to reopen it. Thank you for your contributions! |
|
@voidmatcha Could you please help to check it? It relates to the react ui issue I think. |
|
@jongyoul Thank you for pointing this out. This PR appears to refactor the server-side binding API for the existing Angular Display functionality, so I don't expect merging it to directly affect the current React UI. Compatibility with existing notebooks and interpreter code that use the Angular Display APIs still needs a separate review, though. I'll take a closer look at that when I have a chance. Support for |
There was a problem hiding this comment.
@Reamer Changing the public Scala API from Any to AnyRef breaks existing calls such as AngularModel("count", 1) and AngularModel("enabled", true).
Could you preserve the public API and handle the conversion internally? I prepared a proposal branch with compatibility fixes and regression tests.
- As-is: numeric and Boolean model creation fails to compile.
- To-be: model creation, bidirectional updates and removal passed in a local Classic UI run.
Separately, I filed ZEPPELIN-6758 for the New UI notebook-scoped binding issue, so it can be addressed independently of this PR.
This branch has not been deployed
3 participants
What is this PR for?
This pull request removes the raw use of the AngularObject. The generic version has been removed. AngularObject now contains an object reference.
As a result, warnings from the IDE due to raw use disappear. The code is also easier to read.
What type of PR is it?
What is the Jira issue?
How should this be tested?
Questions: