Conversation
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
Should the i18n change come via a separate JIRA? Seems like it touches more code than was expected from the rstcheck feature.
ndimiduk
left a comment
ndimiduk
left a comment
There was a problem hiding this comment.
ant, cmake, gradel, maven, make all follow the --foo-cmd pattern.
|
|
||
| for i in "$@"; do | ||
| case ${i} in | ||
| --rstcheck=*) |
There was a problem hiding this comment.
This should be --rstcheck-cmd, so as to be consistent with our other plugins that permit specifying the executable path?
There was a problem hiding this comment.
precommit is wildly inconsistent here. Some use --foo-cmd= and some use --foo=. There should really be a follow-on JIRA to make these consistent.
I wanted to cover rstcheck support for i18n while I was still thinking about it. Now that the i18n PR is merged, I've rebased on top of the current main in order to pull it in. |
2 participants
No description provided.