[#2730] improvement(common): Move CompositeFileRegion class and do nothing in deallocate method#2731
Merged
zuston merged 2 commits intoapache:masterfrom Mar 2, 2026
Merged
Conversation
… do nothing in deallocate method
Member
Author
|
@maobaolong @zuston Could you please take a look? |
zuston
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CompositeFileRegionclass to uniffle packageWhy are the changes needed?
Since we have already overridden the
release()/release(int decrement)methods, we don't need to do anything in thedeallocate()method. And after this, we no longer need to place it in theio.netty.utilpackage.closes #2730
Does this PR introduce any user-facing change?
No.
How was this patch tested?