Repository navigation
Conversation
0z5a
marked this pull request as ready for review
November 5, 2026 21:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global
relax.median(..., axis=None, keepdims=True)flattens its input for sorting, then currently returns the rank-one intermediate. For example, a(2, 3)input is inferred to return(1, 1), butLegalizeOpschanges the function's return shape to(1,).Reshape the result to one dimension per input dimension, including the scalar case. Add regression coverage for the inferred return type and LLVM runtime values and shapes.
Fixes #20915.
Testing
(1,)for(2, 3)and(2, 3, 4)inputs; the change returned(1, 1)and(1, 1, 1)with the expected lower-median values.pytestfor the new regression file,test_transform_legalize_ops_search_statistical.py, andtest_op_statistical.py: 62 passed.ruff checkandruff format --checkon the changed files: passed.