Repository navigation
Conversation
0z5a
marked this pull request as ready for review
November 5, 2026 22:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InjectPTXAsyncCopycan lower a 16-byte copy tocp.asynceven when the source or destination address is not provably 16-byte aligned. Check declared buffer alignment and symbolic offsets before injecting the instruction; preserve the original store otherwise. The check accounts for the byte buffer used by merged dynamic shared memory.Fixes #20912.
Testing
The current pinned TIRx may reject an unaligned vector store after the fallback rather than compile it; this PR prevents emitting an unsafe async copy, while a scalar-store fallback is a separate follow-up.