Conversation
Make the shared primitive layer own immediate node definitions, numeric constructors, reflection registrations, and FFI conversion traits. Update C++ consumers to use the primitive namespace and route Python constructors and type keys through prim while retaining tirx aliases.
Keep IRBuilder constant-construction methods and their member calls in the builder class while referring to shared immediate node types through prim.
tlopex
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the canonical C++ definitions, constructors, reflection registrations, and FFI conversion traits for
IntImmandFloatImminto the shared primitive IR layer. Update C++ consumers and headers to usetvm::prim, and route the existing Python primitive classes through theprim.IntImmandprim.FloatImmconstructors and type keys.Preserve numeric construction and BigInt semantics, structural operations, and the existing Python
tirxaliases. Reflection examples and serialization expectations now use the canonicalprimnames.