[Fix][Codegen] Preserve NaNs in floating-point min and max - #20054
Open
tlopex wants to merge 3 commits into
Open
[Fix][Codegen] Preserve NaNs in floating-point min and max#20054tlopex wants to merge 3 commits into
tlopex wants to merge 3 commits into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes NaN handling in floating-point
minandmaxcode generation, partly fixed #19579Previously, the ordered comparison caused a NaN in the left operand to be discarded, while a NaN in the right operand was preserved.
For floating-point operands, this PR implements the following semantics:
This preserves a NaN from either operand while retaining the existing behavior of selecting the second operand when the operands compare equal.
For the C host backend,
a != ais used as the NaN check:This compact form also produces better optimized code than the equivalent nested conditional expression.
For LLVM, the lowering combines an ordered comparison with an unordered self-comparison and emits a single select. This avoids relying on
llvm.maximum/llvm.minimum, whose signed-zero semantics differ from the existing TVM behavior and whose legalization may vary across LLVM targets.