Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI end-to-end tests currently call
run_cli()inside Google Test and depend on the C++ source/build tree. They cannot be reused directly to validate a separately installed CLI.Move executable-level scenarios into a standalone
cpp/test/tools/e2e/bundle containingcases.json, fixtures, goldens, and a Python standard-library runner. The runner invokes the specified executable, checks exit status independently from stdout/stderr and exported files, preserves multi-command write/read scenarios, and retains actual outputs, exit codes, diffs, and identity hashes. Existing parser and injected metadata/stream failure tests remain C++ unit tests.The bundle has 155 cases and 1,076 command invocations, preserves the original 141 goldens, and adds read-back checks for successful writes plus a redirected-stdin round trip. CTest runs the same bundle against the build-tree CLI; CI uploads failure results. Python 3.9+ is required when tools and tests are enabled. Product implementation code is unchanged.
Validation on macOS ARM64:
TsFile_Testpassed; 42 retained CLI/parser/format/statistics unit tests passed.CliE2EandCliE2ERunnerTestpassed: all 155 cases / 1,076 commands and 14 runner regression tests.Usage: