Honor valueless max-stale requests - #13546
Open
bneradt wants to merge 1 commit into
Open
Conversation
bneradt
force-pushed
the
fix-valueless-max-stale
branch
from
August 13, 2026 19:52
09cb863 to
5421cf2
Compare
Contributor
Author
|
Backport note: this change is only needed on master. The 10.x branches already handle valueless max-stale correctly, so no 10.x backport is necessary. |
A valueless Cache-Control: max-stale directive permits clients to accept responses stale by any amount. Header cooking instead discarded the directive, causing ATS to revalidate an otherwise acceptable cached response. Commit d3196a8 ("Ignore malformed Cache-Control directives per RFC 7234", apache#12670) introduced the regression by treating every numeric directive without an equals sign as malformed. This patch represents valueless max-stale with the existing unlimited sentinel and adds parser and end-to-end regression coverage.
bneradt
force-pushed
the
fix-valueless-max-stale
branch
from
August 13, 2026 19:56
5421cf2 to
fc4490b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valueless Cache-Control: max-stale directive permits clients to
accept responses stale by any amount. Header cooking instead discarded
the directive, causing ATS to revalidate an otherwise acceptable cached
response.
Commit d3196a8 ("Ignore malformed
Cache-Control directives per RFC 7234", #12670) introduced the
regression by treating every numeric directive without an equals sign
as malformed.
This patch represents valueless max-stale with the existing unlimited
sentinel and adds parser and end-to-end regression coverage.