Skip to content

Guard against a null hook list in HttpHookState::Scope::init #13542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bryancall wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Draft

Guard against a null hook list in HttpHookState::Scope::init #13542

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19f8532
Guard against a null hook list in HttpHookState::Scope::init
bryancall Aug 13, 2026
daee03e
Correct the rationale in the comment
bryancall Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/api/HttpHookState.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,12 @@ HttpHookState::getNext()
void
HttpHookState::Scope::init(HttpAPIHooks const *feature_hooks, TSHttpHookID id)
{
// operator[] yields nullptr for an out of range id, and a release build can reach that: the only thing rejecting a
// bad hook id upstream is an assert that compiles out. Leave the scope empty rather than dereferencing null.
_hooks = (*feature_hooks)[id];

_p = nullptr;
_c = _hooks->head();
_c = _hooks ? _hooks->head() : nullptr;
}

APIHook const *
Expand Down