Repository navigation
Treat interleaved non-CONTINUATION frame on same stream as PROTOCOL_ERROR - #1132
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
…RROR RFC 9113, section 4.3 states that any frame other than CONTINUATION received while a header block is in progress MUST be treated as a connection error of type PROTOCOL_ERROR. Http2Parser.validateFrame() was using COMPRESSION_ERROR for this case when the offending frame arrived on the same stream as the open header block. Changed the error code to PROTOCOL_ERROR to match the RFC. Add TestHttp2Section_4_3#testHeaderContinuationInterleavedDataSameStream to prove the violation and verify the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9113, section 4.3 states:
Http2Parser.validateFrame()threw a connection error of typeCOMPRESSION_ERRORwhen a non-CONTINUATION, non-RST_STREAM frame arrived on the same stream as an open header block. The correct error code per the RFC isPROTOCOL_ERROR.Fix: change the error code from
COMPRESSION_ERRORtoPROTOCOL_ERRORin thewrongFrameTypebranch ofvalidateFrame().Add
TestHttp2Section_4_3#testHeaderContinuationInterleavedDataSameStreamto prove the violation (sends a DATA frame on the same stream while a header block is in progress) and verify the fix.