[eugenegujing]

What changes were proposed in this PR?

Root cause: VolcanoPlotOpDesc.generatePythonCode hard-codes the y column as the literal "-log10(pvalue)" and plots it under that name, so the y axis always says -log10(pvalue) even when the selected column is padj. The title is the literal "Volcano Plot" and the x axis and color bar show the raw effect column name. None of this can be changed from the property panel.

Before:  P-Value Column = padj  ->  y column "-log10(pvalue)"  ->  y axis "-log10(pvalue)"
After:   P-Value Column = padj  ->  y column "-log10(padj)"    ->  y axis "-log10(padj)", or the Y Label the user typed

The y column is now named after the selected p-value column, so the axis and the hover text say which column was transformed. Three optional label properties are added, empty by default:

Property	Empty	Set
Title	Volcano Plot	the text typed
X Label	effect column name	the text typed
Y Label	-log10(<p-value column>)	the text typed

The color bar has no label of its own: the points are colored by the effect column, the same column that is on the x axis, so the color bar carries the X Label text (or the effect column name when X Label is empty). If a later change lets the color encode a different column, a label for it would come with that change.

The labels go through fig.update_layout(xaxis_title, yaxis_title, coloraxis_colorbar_title_text), same as Line Chart's X Label / Y Label. Each label is an EncodableString, so quotes and non-ASCII text are fine. A whitespace-only field counts as empty. The hover box still shows raw column names (plotly behaviour, same as Line Chart).

Behavior change for saved workflows: a workflow with padj as the p-value column now renders -log10(padj) instead of -log10(pvalue). That is the fix.

Since #8504 merged, the operator also has an export path, generateStandaloneCode(), which writes the same figure as a standalone script. It carried the same hard-coded "-log10(pvalue)" and title="Volcano Plot", so this PR applies the same change there: the y column is named after the selected p-value column and the three labels go through fig.update_layout as escaped Python literals (the export has no decoder, so pyStringLiteral escapes quotes and backslashes). The engine template and the exported script now label the figure the same way, and a spec checks that across the label combinations.

Rebase note: coloraxis_colorbar_title_text is emitted unconditionally, in both templates. Once the significance-coloring PR (#9039) lands, the categorical mode has no coloraxis, so whichever branch rebases second needs to make that entry conditional.

Figures below are the operator's generated Python from main and from this branch, run on the 430-gene example workflow from the issue; the third one has the title and both axis labels filled in.

Before	After (defaults)	After (labels set)

Any related issues, documentation, discussions?

Closes #9037

PR #8504 (merged) added the generateStandaloneCode() export path with the same hard-coded "-log10(pvalue)"; the mirroring described above is the follow-up it needed.

How was this PR tested?

New tests in VolcanoPlotOpDescSpec, written before the source change:

• y column and axis are named after the selected p-value column; the old literal is gone
• every label falls back to its default when empty or whitespace-only
• a set label replaces its default and reaches the code only as a decode site (sentinels with quotes, backslash, non-ASCII)
• the color bar title follows X Label when it is set and the effect column name otherwise
• one set label leaves the other two at their defaults
• a workflow JSON saved before this change (only the two column keys) generates byte-for-byte the same code as a default-constructed operator
• generateStandaloneCode: the y column and axis are named after the p-value column (including a name with a quote, p"adj), the labels fall back to the column-derived defaults, a set label is emitted as an escaped literal and the default title is gone, the color bar carries the X Label text, whitespace-only keeps the default, a saved workflow renders as a default-constructed operator, and a cross-path test with the title and X Label set checks that the engine template and the exported script carry the same title, axis and color bar labels

sbt -Dsbt.server.forcestart=true "WorkflowOperator/testOnly *VolcanoPlotOpDescSpec"
# Tests: succeeded 18, failed 0, canceled 0, ignored 0, pending 1   (the pending one is pre-existing)

sbt -Dsbt.server.forcestart=true "WorkflowOperator/scalafmtAll" "WorkflowOperator/Test/scalafmtAll"
sbt -Dsbt.server.forcestart=true "WorkflowOperator/scalafixAll --check"
# success

Smoke run: the generated code was executed outside Texera (pytexera stubbed, pandas + plotly 5.24.1) on the 430-gene mock table. Defaults give title Volcano Plot, x lfc_shrunk, y -log10(padj), color bar lfc_shrunk; with the labels set the figure shows the typed text; whitespace-only title and y label fall back to the defaults. The exported script for the default and the all-labels configuration parses with ast.parse.

Was this PR authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with Claude; the author reviewed the change before submission.

[github-actions]

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

• Contributors with relevant context: @aglinxinyuan, @Yicong-Huang
  You can notify them by mentioning @aglinxinyuan, @Yicong-Huang in a comment.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.79%. Comparing base (d6c9050) to head (43eb989).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9040      +/-   ##
============================================
- Coverage     91.85%   91.79%   -0.06%     
- Complexity     5020     5032      +12     
============================================
  Files          1279     1273       -6     
  Lines         56192    55594     -598     
  Branches       7320     7156     -164     
============================================
- Hits          51615    51033     -582     
- Misses         2741     2750       +9     
+ Partials       1836     1811      -25     

Flag	Coverage Δ		*Carryforward flag
access-control-service	77.44% <ø> (ø)
agent-service	99.53% <ø> (ø)		Carriedforward from 11ab0ce
amber	85.96% <100.00%> (+0.06%)	⬆️
computing-unit-managing-service	64.05% <ø> (ø)
config-service	87.61% <ø> (ø)
file-service	82.29% <ø> (ø)
frontend	96.46% <ø> (-0.08%)	⬇️	Carriedforward from 11ab0ce
notebook-migration-service	83.77% <ø> (ø)
pyamber	98.54% <ø> (+0.07%)	⬆️	Carriedforward from 11ab0ce
workflow-compiling-service	77.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

⚠️ Benchmark changes need a look

🟢 4 better · 🔴 4 worse · ⚪ 7 noise (<±5%) · 0 without baseline

Compared against main d6c9050 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

	config	throughput	MB/s	latency	max Δ latest / 7d
🔴	bs=10 sw=10 sl=64	550	0.336	17,171/26,216/26,216 us	🟢 -7.3% / 🔴 +103.4%
🟢	bs=100 sw=10 sl=64	1,215	0.741	81,623/96,839/96,839 us	🟢 -22.6% / 🔴 +8.8%
🔴	bs=1000 sw=10 sl=64	1,385	0.845	717,743/861,116/861,116 us	🔴 +17.5% / 🟢 -12.0%

Baseline details

Latest main d6c9050 from same runner

config	metric	PR	latest main	7d avg	Δ latest	Δ 7d
bs=10 sw=10 sl=64	throughput	550 tuples/sec	584 tuples/sec	953.99 tuples/sec	-5.8%	-42.3%
bs=10 sw=10 sl=64	MB/s	0.336 MB/s	0.357 MB/s	0.582 MB/s	-5.9%	-42.3%
bs=10 sw=10 sl=64	p50	17,171 us	17,862 us	10,584 us	-3.9%	+62.2%
bs=10 sw=10 sl=64	p95	26,216 us	28,267 us	12,888 us	-7.3%	+103.4%
bs=10 sw=10 sl=64	p99	26,216 us	28,267 us	16,266 us	-7.3%	+61.2%
bs=100 sw=10 sl=64	throughput	1,215 tuples/sec	1,172 tuples/sec	1,242 tuples/sec	+3.7%	-2.2%
bs=100 sw=10 sl=64	MB/s	0.741 MB/s	0.715 MB/s	0.758 MB/s	+3.6%	-2.3%
bs=100 sw=10 sl=64	p50	81,623 us	78,531 us	83,370 us	+3.9%	-2.1%
bs=100 sw=10 sl=64	p95	96,839 us	125,052 us	88,966 us	-22.6%	+8.8%
bs=100 sw=10 sl=64	p99	96,839 us	125,052 us	101,186 us	-22.6%	-4.3%
bs=1000 sw=10 sl=64	throughput	1,385 tuples/sec	1,451 tuples/sec	1,276 tuples/sec	-4.5%	+8.5%
bs=1000 sw=10 sl=64	MB/s	0.845 MB/s	0.886 MB/s	0.779 MB/s	-4.6%	+8.5%
bs=1000 sw=10 sl=64	p50	717,743 us	687,911 us	815,662 us	+4.3%	-12.0%
bs=1000 sw=10 sl=64	p95	861,116 us	732,771 us	864,800 us	+17.5%	-0.4%
bs=1000 sw=10 sl=64	p99	861,116 us	732,771 us	896,884 us	+17.5%	-4.0%

Raw CSV

config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,363.72,200,128000,550,0.336,17171.22,26215.72,26215.72
1,100,10,64,20,1646.53,2000,1280000,1215,0.741,81622.80,96838.64,96838.64
2,1000,10,64,20,14443.13,20000,12800000,1385,0.845,717742.80,861115.90,861115.90

[kz930]

The color bar always shows the effect column, which is the same column as the x axis, so is a separate Color Bar Label needed, or could it follow X Label?

[eugenegujing]

@kz930 You're correct. The color bar now takes the X Label text and the separate Color Bar Label property is removed in 969e324