Repository navigation
Conversation
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8481 +/- ##
============================================
- Coverage 92.21% 92.20% -0.02%
- Complexity 4977 4995 +18
============================================
Files 1275 1277 +2
Lines 55649 55623 -26
Branches 7163 7167 +4
============================================
- Hits 51318 51285 -33
- Misses 2555 2557 +2
- Partials 1776 1781 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 390 | 0.238 | 25,076/32,227/32,227 us | 🔴 +28.5% / 🔴 +145.5% |
| 🔴 | bs=100 sw=10 sl=64 | 789 | 0.482 | 127,908/155,432/155,432 us | 🔴 +20.8% / 🔴 +70.6% |
| ⚪ | bs=1000 sw=10 sl=64 | 979 | 0.597 | 1,021,095/1,063,785/1,063,785 us | ⚪ within ±5% / 🔴 +21.5% |
Baseline details
Latest main cf6faeb from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 390 tuples/sec | 455 tuples/sec | 931.98 tuples/sec | -14.3% | -58.2% |
| bs=10 sw=10 sl=64 | MB/s | 0.238 MB/s | 0.278 MB/s | 0.569 MB/s | -14.4% | -58.2% |
| bs=10 sw=10 sl=64 | p50 | 25,076 us | 19,516 us | 10,818 us | +28.5% | +131.8% |
| bs=10 sw=10 sl=64 | p95 | 32,227 us | 32,689 us | 13,127 us | -1.4% | +145.5% |
| bs=10 sw=10 sl=64 | p99 | 32,227 us | 32,689 us | 16,504 us | -1.4% | +95.3% |
| bs=100 sw=10 sl=64 | throughput | 789 tuples/sec | 891 tuples/sec | 1,210 tuples/sec | -11.4% | -34.8% |
| bs=100 sw=10 sl=64 | MB/s | 0.482 MB/s | 0.544 MB/s | 0.739 MB/s | -11.4% | -34.8% |
| bs=100 sw=10 sl=64 | p50 | 127,908 us | 112,189 us | 85,326 us | +14.0% | +49.9% |
| bs=100 sw=10 sl=64 | p95 | 155,432 us | 128,687 us | 91,092 us | +20.8% | +70.6% |
| bs=100 sw=10 sl=64 | p99 | 155,432 us | 128,687 us | 102,379 us | +20.8% | +51.8% |
| bs=1000 sw=10 sl=64 | throughput | 979 tuples/sec | 988 tuples/sec | 1,240 tuples/sec | -0.9% | -21.0% |
| bs=1000 sw=10 sl=64 | MB/s | 0.597 MB/s | 0.603 MB/s | 0.757 MB/s | -1.0% | -21.1% |
| bs=1000 sw=10 sl=64 | p50 | 1,021,095 us | 1,011,356 us | 840,622 us | +1.0% | +21.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,063,785 us | 1,051,421 us | 889,172 us | +1.2% | +19.6% |
| bs=1000 sw=10 sl=64 | p99 | 1,063,785 us | 1,051,421 us | 931,615 us | +1.2% | +14.2% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.70,200,128000,390,0.238,25076.13,32226.85,32226.85
1,100,10,64,20,2533.96,2000,1280000,789,0.482,127907.73,155432.27,155432.27
2,1000,10,64,20,20430.92,20000,12800000,979,0.597,1021095.35,1063785.19,1063785.19
carloea2
left a comment
There was a problem hiding this comment.
Additional boundary cases reproduced with compiled local tests.
The same gap as the timestamp parts, on the other kind of column. Grouping by a continuous number puts almost every row in a group of its own, so counts per age bracket or per price band could not be asked for; a user wanting them had to write a Python UDF. Two cuts, because they answer different questions. Equal width divides the span into bins of one size; equal frequency cuts at the quantiles, so the bins hold about as many rows as each other. The second is why the operator reads the whole table before it emits: a quantile is not known until the last row has arrived. The bin reads as its own range, "(2.5, 5.0]", which is a label to group by rather than a number to do arithmetic on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
An equal-width cut has no edges to find when every cell of the column is empty, and none when no row arrived at all, so pandas raises before the suffix that keeps a hole a hole can run. Both renderings now skip the cut in that case and let the suffix turn the holes into the empty bin labels they already are. The equal-frequency cut does not raise on the same table, but it goes through the same guard: one shape of answer for a table with nothing in it, whichever way it was asked to cut. Two tests run the exported script over an all-empty column, an empty table and a column with one hole, since the defect is what pandas does at runtime rather than what the operator writes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
@carloea2 the finding is fixed: a column with nothing in it skips the cut, so the rows keep null bin labels. Would you take another look when you have a moment? |
carloea2
left a comment
There was a problem hiding this comment.
The all missing column case is handled now. Looks good.
…-integration Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
carloea2
left a comment
There was a problem hiding this comment.
All 13 existing tests and formatting checks pass. A new parity test using the real table-operator lifecycle fails on stored NaNs in nullable Arrow input; the mixed-value control passes.
A nullable Float64 column read from Arrow can hold NaN as a value, which notna() reports present, so an all-NaN column reached pd.cut and raised on duplicate edges while the engine path left it uncut. The guard now tests a float64 view. Adds a stored-NaN case to the runtime test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
carloea2
left a comment
There was a problem hiding this comment.
The stored NaN fix passes. All 14 focused tests pass, including my original reproduction run through the real UDF lifecycle and generated export for both equal-width and equal-frequency binning. Mixed finite values agree; all stored NaNs produce empty bins. The UDF probe uses the #8766 SDK. Formatting passes. No new finding in this update.
sbt -batch 'WorkflowOperator/testOnly *BinningOpDescSpec -- -oDF' 'scalafmtCheckAll'
Python's open() defaults to the locale's encoding, which is cp1252 on Windows, while the spec writes these files as UTF-8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
carloea2
left a comment
There was a problem hiding this comment.
All 13 focused tests and formatting checks pass on a fresh detached checkout. The binning implementation is unchanged from the stored-NaN fix verified earlier; this update fixes the test driver's encoding. The remaining CI failure is LoopIntegrationSpec, covered by #8938. Looks good. Leaving the draft status unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
carloea2
left a comment
There was a problem hiding this comment.
Binning fails on valid LONG values.
pandas builds edges in float64, which cannot count by one past 2**53, so an equal-width cut raised on duplicate edges and a quantile cut merged the rows into one bin. An integer column is now cut as its distance from the value nearest zero, and that value is added back to the labels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cutting every integer column as a distance changed the labels pandas rounds, so 723.062 could read 723.0625. The shifted cut is now used only where the plain one raises or loses a bin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@carloea2 Large LONG values now keep separate bins in both paths, and ordinary columns keep pandas' labels. Could you take another look? |
carloea2
left a comment
There was a problem hiding this comment.
Equal-width binning still loses precision at the Int64 limits. The branch also conflicts with current main.
…e same bin Comparing category counts missed Int64 values near the limit, where the plain cut keeps all bins but puts every row in one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/LogicalOp.scala
|
@carloea2 may you take another look? |
What changes were proposed in this PR?
An operator that cuts a numeric column into bins and adds the bin a row fell in as a column of its own.
Two cuts, because they answer different questions. Equal width divides the span into bins of one size; equal frequency cuts at the quantiles, so the bins hold about as many rows as each other. The second is why the operator reads the whole table before it emits: a quantile is not known until the last row has arrived.
The bin reads as its own range,
(2.5, 5.0], which is a label to group by rather than a number to do arithmetic on.Any related issues, documentation, discussions?
Not part of #8325: that set makes the operators Texera already had exportable. This adds a new one, which implements the trait from the start rather than gaining it. The trait is in #8327, which has merged.
Closes #8479, the task this change is the whole of.
The same gap as #8478, on the other kind of column. Grouping by a continuous number puts almost every row in a group of its own, so counts per age bracket or per price band could not be asked for; a user wanting them had to write a Python UDF.
How was this PR tested?
Ten unit tests in the operator's own spec, over the schema it declares and the Python it emits on both paths. The parity harness runs it on four configurations, one per cut plus a hostile column name and an empty cell, comparing the engine's answer against the exported script's.
The operator in the editor, cutting
scoreinto four equal-width bins:Each row's bin beside the value it came from, named by the range it fell in rather than by a number:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)