chore(amber): remove the never-registered MockKillWorkerResource

[aglinxinyuan]

What changes were proposed in this PR?

Deletes MockKillWorkerResource, a JAX-RS resource that is never registered and therefore never served. Pure deletion, no behaviour change: −40 lines.

History

Introduced by	the initial amber import, commit 41a8a92017 (2020-08-20) — predates the PR workflow — and registered with Jersey at the time
Usage removed by	commit 134bc9ba64 (2020-11-29) — "migrate UserResource" dropped it from the Jersey registration imports. A commented-out placeholder, // environment.jersey().register(classOf[MockKillWorkerResource]), was later reintroduced by #1394 (2022-01-26, "Fix Guest Auth") and has sat commented ever since

Dead for about six years — the longest-standing item in this cleanup series. The commented-out registration line goes with the class.

Any related issues, documentation, discussions?

Closes #8393

How was this PR tested?

Existing tests only — no spec referenced the resource.

Locally, from the repo root with Java 17:

• sbt "WorkflowExecutionService/Test/compile" — success.
• sbt scalafmtCheckAll "scalafixAll --check" — clean.

Verification, re-runnable by a reviewer:

git grep -n MockKillWorkerResource            # only the deleted file and the commented registration
git grep -n "jersey.register" -- amber/src/main   # the live registrations, untouched

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

[github-actions]

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

• Contributors with relevant context: @Neilk1021
  You can notify them by mentioning @Neilk1021 in a comment.

[Copilot]

🟢 Approval recommended

The change is a straightforward cleanup (dead code/comment removal) and repository-wide search shows no remaining references.

Pull request overview

Removes a long-dead Amber Dropwizard/Jersey endpoint stub (MockKillWorkerResource) that was never actually registered/served, simplifying the web service surface area without changing runtime behavior.

Changes:

• Removed the commented-out Jersey registration line for MockKillWorkerResource from TexeraWebApplication.
• Deleted the MockKillWorkerResource.scala file (which contained only commented-out code).

File summaries

File	Description
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala	Removes the leftover commented Jersey registration for the dead resource.
amber/src/main/scala/org/apache/texera/web/resource/MockKillWorkerResource.scala	Deletes the unused, never-registered resource stub file.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

⚠️ Benchmark changes need a look

🟢 2 better · 🔴 7 worse · ⚪ 6 noise (<±5%) · 0 without baseline

Compared against main 1cbe857 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

	config	throughput	MB/s	latency	max Δ latest / 7d
🔴	bs=10 sw=10 sl=64	545	0.333	17,093/27,227/27,227 us	🔴 +20.9% / 🔴 +70.4%
🔴	bs=100 sw=10 sl=64	1,193	0.728	82,622/116,312/116,312 us	🔴 +16.4% / 🟢 +22.2%
🟢	bs=1000 sw=10 sl=64	1,418	0.866	702,938/793,290/793,290 us	🟢 -6.7% / 🟢 +41.0%

Baseline details

Latest main 1cbe857 from same runner

config	metric	PR	latest main	7d avg	Δ latest	Δ 7d
bs=10 sw=10 sl=64	throughput	545 tuples/sec	640 tuples/sec	755.36 tuples/sec	-14.8%	-27.8%
bs=10 sw=10 sl=64	MB/s	0.333 MB/s	0.39 MB/s	0.461 MB/s	-14.6%	-27.8%
bs=10 sw=10 sl=64	p50	17,093 us	14,138 us	12,938 us	+20.9%	+32.1%
bs=10 sw=10 sl=64	p95	27,227 us	25,017 us	15,980 us	+8.8%	+70.4%
bs=10 sw=10 sl=64	p99	27,227 us	25,017 us	19,233 us	+8.8%	+41.6%
bs=100 sw=10 sl=64	throughput	1,193 tuples/sec	1,218 tuples/sec	976.3 tuples/sec	-2.1%	+22.2%
bs=100 sw=10 sl=64	MB/s	0.728 MB/s	0.743 MB/s	0.596 MB/s	-2.0%	+22.2%
bs=100 sw=10 sl=64	p50	82,622 us	79,797 us	102,340 us	+3.5%	-19.3%
bs=100 sw=10 sl=64	p95	116,312 us	99,915 us	109,262 us	+16.4%	+6.5%
bs=100 sw=10 sl=64	p99	116,312 us	99,915 us	118,827 us	+16.4%	-2.1%
bs=1000 sw=10 sl=64	throughput	1,418 tuples/sec	1,403 tuples/sec	1,006 tuples/sec	+1.1%	+40.9%
bs=1000 sw=10 sl=64	MB/s	0.866 MB/s	0.856 MB/s	0.614 MB/s	+1.2%	+41.0%
bs=1000 sw=10 sl=64	p50	702,938 us	698,287 us	999,855 us	+0.7%	-29.7%
bs=1000 sw=10 sl=64	p95	793,290 us	850,512 us	1,042,833 us	-6.7%	-23.9%
bs=1000 sw=10 sl=64	p99	793,290 us	850,512 us	1,070,722 us	-6.7%	-25.9%

Raw CSV

config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,366.79,200,128000,545,0.333,17092.54,27226.66,27226.66
1,100,10,64,20,1675.97,2000,1280000,1193,0.728,82621.86,116312.21,116312.21
2,1000,10,64,20,14100.57,20000,12800000,1418,0.866,702937.89,793290.01,793290.01

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (1cbe857) to head (5219053).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #8396      +/-   ##
============================================
- Coverage     94.03%   94.02%   -0.01%     
+ Complexity     4821     4820       -1     
============================================
  Files          1204     1204              
  Lines         48991    48991              
  Branches       5956     5956              
============================================
- Hits          46067    46066       -1     
  Misses         1458     1458              
- Partials       1466     1467       +1     

Flag	Coverage Δ		*Carryforward flag
access-control-service	81.00% <ø> (ø)		Carriedforward from 1cbe857
agent-service	99.32% <ø> (ø)		Carriedforward from 1cbe857
amber	89.91% <ø> (-0.01%)	⬇️
computing-unit-managing-service	73.67% <ø> (ø)		Carriedforward from 1cbe857
config-service	87.12% <ø> (ø)		Carriedforward from 1cbe857
file-service	87.91% <ø> (ø)		Carriedforward from 1cbe857
frontend	96.79% <ø> (ø)		Carriedforward from 1cbe857
notebook-migration-service	83.57% <ø> (ø)		Carriedforward from 1cbe857
pyamber	98.47% <ø> (ø)		Carriedforward from 1cbe857
workflow-compiling-service	77.19% <ø> (ø)		Carriedforward from 1cbe857

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.