feat(workflow-form): Form View title bar, save, and modification lock - #8391
Draft
yangzhang75 wants to merge 2 commits into
Draft
feat(workflow-form): Form View title bar, save, and modification lock#8391yangzhang75 wants to merge 2 commits into
yangzhang75 wants to merge 2 commits into
Conversation
…harness The read-only shell of the Form View page: behind the feature flag it loads the workflow the URL names, redirects to the operator canvas when the workflow does not open in the form (or the flag is off), shows it read-only, hands back to the canvas, and releases the shared singleton services on the way out. The title bar's rename/save, the read-only preview, the inputs, running and results are added on top by later PRs. Also adds the shared spec harness (workflow-form.spec-harness.ts) these specs build the component from; later slices extend it with the mocks they introduce. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8391 +/- ##
============================================
- Coverage 94.02% 93.97% -0.06%
Complexity 4819 4819
============================================
Files 1202 1207 +5
Lines 48925 49151 +226
Branches 5942 5969 +27
============================================
+ Hits 46002 46188 +186
- Misses 1459 1489 +30
- Partials 1464 1474 +10
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
On top of the page shell: the title bar's workflow name (renamable in place, exactly as on the operator canvas), its 'Saved at ...' state, and the debounced save both views share -- so an edit made in the form is not lost on the canvas, and vice versa. A save fills in a position for every operator and reports a failure rather than losing it silently. The read-only preview, inputs, running and results are added by later PRs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yangzhang75
force-pushed
the
formview-pr7
branch
from
September 4, 2026 04:59
11ba947 to
418e104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Building on the Form View page shell (#8376), this PR adds the title bar and the save it needs (parent issue #8011). Frontend only.
workflowMetaDataChangedsubscription the canvas uses, so a rename or save (this page's own, or a co-editor's) refreshes the name, its width, and the saved-at state from one place, and the two views never drift apart.disableWorkflowModification): the graph and its properties are shown, not edited. A later PR's authoring mode makes them editable with write access.The read-only preview, the inputs, running and results are added by later PRs.
Screenshot
The title bar (renamable name, "Saved at ..." state, the Canvas / Form View switch) on the read-only page:

Any related issues, documentation, discussions?
Part of the Form View feature (parent issue #8011); stacked on #8376 (the page shell). Until #8376 merges, this PR's diff includes that PR's commit as well.
How was this PR tested?
Unit tests (vitest):
workflow-form.component.spec.ts(21 tests). As with the shell, the component injects heavy services and child components, so its spec constructs it directly with the shared harness's mocks rather than through TestBed; template rendering is therefore not exercised, but the component and the harness are at 100% of the TypeScript lines this PR adds. The template compiles cleanly underng build.Was this PR authored or co-authored using generative AI tooling?
Yes. Co-authored with Claude (Anthropic), reviewed line by line by the author before submission.