Skip to content

feat(pyamber): hash large binary tuples #8244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carloea2 wants to merge 1 commit into from
Closed

feat(pyamber): hash large binary tuples #8244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions amber/src/main/python/core/models/tuple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,9 @@ def __hash__(self) -> int:
AttributeType.STRING: lambda f: java_hash_bytes(map(ord, f), 0, salt),
AttributeType.TIMESTAMP: lambda f: java_hash_long(int(f.timestamp())),
AttributeType.BINARY: lambda f: java_hash_bytes(f, 1, salt),
AttributeType.LARGE_BINARY: lambda f: int_32(
salt + java_hash_bytes(map(ord, f.uri), 0, salt)
),
}

for name, field in self.as_key_value_pairs():
Expand Down
7 changes: 7 additions & 0 deletions amber/src/test/python/core/models/test_tuple.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,13 @@ def test_hash(self):
)
assert hash(tuple5) == -2099556631 # calculated with Java

def test_hash_large_binary_matches_java(self):
from core.models.type.large_binary import largebinary

schema = Schema(raw_schema={"blob": "LARGE_BINARY"})
tuple_ = Tuple({"blob": largebinary("s3://bucket/key")}, schema)
assert hash(tuple_) == 1754254834

def test_tuple_with_large_binary(self):
"""Test tuple with largebinary field."""
from core.models.type.large_binary import largebinary
Expand Down
Loading