Skip to content

fix: initialize large-binary S3 bucket at startup to prevent NoSuchBucketException #4241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kunwp1 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −2
Open

fix: initialize large-binary S3 bucket at startup to prevent NoSuchBucketException #4241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c130f4
Fix
kunwp1 Feb 26, 2026
ec23392
Merge branch 'main' into chris-fix-4239
kunwp1 Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import io.dropwizard.setup.{Bootstrap, Environment}
import io.dropwizard.websockets.WebsocketBundle
import org.apache.texera.amber.config.StorageConfig
import org.apache.texera.amber.engine.common.Utils
import org.apache.texera.service.util.LargeBinaryManager
import org.apache.texera.amber.util.ObjectMapperUtils
import org.apache.texera.auth.SessionUser
import org.apache.texera.dao.SqlServer
Expand Down Expand Up @@ -104,6 +105,9 @@ class TexeraWebApplication
StorageConfig.jdbcPassword
)

// ensure the large-binary S3 bucket exists before any workflow execution attempts to use it
LargeBinaryManager.initialize()

// redirect all 404 to index page, according to Angular routing requirements
val eph = new ErrorPageErrorHandler
eph.addErrorPage(404, "/")
Expand Down
9 changes: 7 additions & 2 deletions common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,20 @@ import java.util.UUID
object LargeBinaryManager extends LazyLogging {
private val DEFAULT_BUCKET = "texera-large-binaries"

/**
* Ensures the large-binary bucket exists. Should be called once at service startup.
*/
def initialize(): Unit = {
S3StorageClient.createBucketIfNotExist(DEFAULT_BUCKET)
}

/**
* Creates a new LargeBinary reference.
* The actual data upload happens separately via LargeBinaryOutputStream.
*
* @return S3 URI string for the new LargeBinary (format: s3://bucket/key)
*/
def create(): String = {
S3StorageClient.createBucketIfNotExist(DEFAULT_BUCKET)

val objectKey = s"objects/${System.currentTimeMillis()}/${UUID.randomUUID()}"
val uri = s"s3://$DEFAULT_BUCKET/$objectKey"

Expand Down
Loading