[SYSTEMDS-3894] Add OOC covariance and extend TSMM support#2529
Open
tuluyhansozen wants to merge 5 commits into
Open
[SYSTEMDS-3894] Add OOC covariance and extend TSMM support#2529tuluyhansozen wants to merge 5 commits into
tuluyhansozen wants to merge 5 commits into
Conversation
tuluyhansozen
force-pushed
the
aditya-amls-test-branch
branch
from
July 2, 2026 09:59
7f235ad to
0c121eb
Compare
tuluyhansozen
marked this pull request as ready for review
July 2, 2026 10:04
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
=========================================
Coverage 71.59% 71.59%
- Complexity 49893 49922 +29
=========================================
Files 1602 1603 +1
Lines 193154 193251 +97
Branches 37817 37829 +12
=========================================
+ Hits 138290 138361 +71
- Misses 44089 44108 +19
- Partials 10775 10782 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@janniklinde we solved conflicts and failing checks and created a fresh clean pr. |
janniklinde
reviewed
Jul 3, 2026
Contributor
There was a problem hiding this comment.
Thank you for the PR. Overall, these changes look very good to me. I left some minor comments in the code @tuluyhansozen @122Astha @AdityaPandey2612
Contributor
|
Please mark comments as resolved if you have addressed them |
Author
|
Last commit is for format check and rebase from current main @janniklinde |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds out-of-core execution for covariance and extends OOC transpose-self matrix multiplication (TSMM) to support right-side operations and multi-tile outputs.
The PR changes 12 files with 688 additions and 59 deletions, covering 5 runtime files, 3 Java test files, and 4 DML test scripts.
Implementation
OOC Covariance
CovarianceOOCInstructionfor both unweightedcov(A, B)and weightedcov(A, B, W)operations.OOCInstructionParserand the newOOCType.COV.NaNresults.OOC TSMM
TSMMOOCInstructionto support multi-tile results for:t(X) %*% XX %*% t(X)Testing
The targeted test suite contains 11 tests:
Covariance — 4 tests
1871 x 1.1000, producing two input blocks.0.65.0.05.1e-10.ooc_covinstruction is present in the heavy hitters.TSMM — 7 tests
2143 x 1231000123 x 123123 x 21431000123 x 1231501 x 13015001301 x 1301across3 x 3blocks1501 x 13015001501 x 1501across4 x 4blocks0.7.0.1.1e-8.ooc_tsmmexecution, output metadata, multi-tile coverage, and off-diagonal symmetry.Test Results