Repository navigation
Conversation
Signed-off-by: Julien Nioche <julien@digitalpebble.com>
jnioche
changed the title
rzo1
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2289, partial revert of #1854
Default now set to 1M
The size should be set to the worker’s heap at about 200 bytes per entry, assuming an average URL size of 59-characters.
1M URLs in the cache would take ~200MB per instance of StatusUpdaterBolt.
Cheaper entries: the cache could store a 64-bit hash of the URL instead of the String, which takes about a half the memory per entry.