IPFilterRules: add anylocal and multicast keywords, fail on unparseable rules - #2119
Open
abhinav-phi wants to merge 1 commit into
Open
IPFilterRules: add anylocal and multicast keywords, fail on unparseable rules#2119abhinav-phi wants to merge 1 commit into
abhinav-phi wants to merge 1 commit into
Conversation
…le rules (apache#2086) A rule that is neither a keyword, a CIDR block nor a single address was logged and dropped, silently widening what the crawler will connect to. Configuration now fails with an IllegalArgumentException instead, so a typo in an exclude list stops the topology rather than removing a rule the operator believed was in force. Adds the anylocal and multicast keywords, documents linklocal (already present but missing from the javadoc), and updates the example in crawler-default.yaml to also cover CGNAT and IPv6 unique-local space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2086 (the part not already covered by #2077).
A rule which is neither a keyword, a CIDR block nor a single IP address was logged and dropped, silently widening what the crawler will connect to. Configuration now throws an
IllegalArgumentExceptioninstead, so a typo in an exclude list stops the topology rather than removing a rule the operator believed was in force.anylocalandmulticastkeywordslinklocalin the class javadoc (it was added by Only follow robots.txt redirects on the same host #2077 but missing from the docs)crawler-default.yamlto also cover CGNAT and IPv6 unique-local spaceinvalidRuleIsIgnoredis replaced byinvalidRuleFailsConfiguration, which asserts the throw