Validate the worker id in profile-docker-container - #9009
Merged
rzo1 merged 1 commit intoAug 23, 2026
Merged
Conversation
profile-docker-container now checks the worker id with validate_container_id before get_docker_container_pid builds the docker command line, and get_docker_container_pid returns pid -1 instead of dereferencing a NULL stream when popen fails. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rzo1
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
profile-docker-container now checks the worker id with validate_container_id before get_docker_container_pid builds the docker command line, and get_docker_container_pid returns pid -1 instead of dereferencing a NULL stream when popen fails.
Stacked on #9008 (targets that branch); GitHub will retarget this to master once #9008 merges.
How this was tested
Built the worker-launcher native tree with
autoreconf -i && ./configure && make check(autotools, compiled with-Werror); the test suite passes.