[SPARK-58893][UI] Fix Spark UI multi-cluster reverse proxy: propagate… - #58243
Open
Nflrijal wants to merge 1 commit into
Open
[SPARK-58893][UI] Fix Spark UI multi-cluster reverse proxy: propagate…#58243Nflrijal wants to merge 1 commit into
Nflrijal wants to merge 1 commit into
Conversation
… reverseProxyUrl to driver, fix redirect Location and kill button
Contributor
Author
|
Hi @dongjoon-hyun, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When
spark.ui.reverseProxy=trueis enabled in Standalone multi-cluster deployments:SparkContexton the driver did not receiveUI_REVERSE_PROXY_URL, causing driver UI links to drop/proxy/<id>prefixes. This PR propagatesUI_REVERSE_PROXY_URL(or falls back tospark.ui.proxyBase) into system propertyspark.ui.proxyBase.Masterdid not pass-Dspark.ui.reverseProxyUrl=<url>toDriverDescriptionjavaOpts. This PR updatesMasterto injectreverseProxyUrlinto driverjavaOptswhen reverse proxy is enabled./app/killand/driver/killredirectLocationheaders were redirecting to/instead ofreverseProxyUrl + "/". This PR updatesMasterWebUIredirect handlers to preserve reverse proxy paths.UIUtils.prependBaseUrianduiRootwere updated to handlerequest = nullsafely.Note: Please backport to
master,branch-4.1, andbranch-3.5if applicable.Why are the changes needed?
Without these changes, multi-cluster reverse proxy deployments lose proxy prefixes when accessing driver UIs or terminating applications/drivers from Master UI, breaking navigation and reverse proxy routing.
Does this PR introduce any user-facing change?
No API changes. Fixes UI navigation links and redirect Location headers when
spark.ui.reverseProxy=trueis enabled.How was this patch tested?
UIUtilsSuite,MasterSuite,MasterWebUISuite, andSparkContextSuite.build/sbt "core/testOnly org.apache.spark.ui.UIUtilsSuite org.apache.spark.deploy.master.MasterSuite org.apache.spark.deploy.master.ui.MasterWebUISuite org.apache.spark.SparkContextSuite".Was this patch authored or co-authored using generative AI tooling?
No.