[SPARK-56921][SQL] Fix CTE ID normalization for nested CTEs#55985
Open
puneetdixit200 wants to merge 1 commit into
Open
[SPARK-56921][SQL] Fix CTE ID normalization for nested CTEs#55985puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This updates
NormalizeCTEIdsso normalization for the currentWithCTEscope does not descend into nestedWithCTEnodes that will be normalized by the normal top-down traversal. This prevents nested CTE refs from being remapped twice when plans contain nestedWithCTEnodes under a union.A regression test covers the reported temp-view + nested CTE + union pattern and forces
queryExecution.normalizedbefore checking the result.How was this patch tested?
git diff --checkJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH="/opt/homebrew/opt/openjdk@17/bin:$PATH" ./build/sbt "sql/testOnly org.apache.spark.sql.CTEInlineSuiteAEOff -- -z SPARK-56921"JAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home PATH="/opt/homebrew/opt/openjdk@17/bin:$PATH" ./build/sbt "sql/testOnly org.apache.spark.sql.CTEInlineSuiteAEOn -- -z SPARK-56921"