[SPARK-56944] [SQL] Trim aliases from ListAgg expression subtree#55984
Open
mihailoale-db wants to merge 1 commit into
Open
[SPARK-56944] [SQL] Trim aliases from ListAgg expression subtree#55984mihailoale-db wants to merge 1 commit into
mihailoale-db wants to merge 1 commit into
Conversation
mihailoale-db
changed the title
Contributor
Author
|
@cloud-fan PTAL when you find time. Thanks! |
cloud-fan
reviewed
May 20, 2026
Contributor
cloud-fan
left a comment
cloud-fan
left a comment
There was a problem hiding this comment.
Thanks Mihailo, the fix is reasonable and follows the pattern from SPARK-54871.
One question about completeness, and one about test coverage — see inline. Otherwise the change is straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR I propose to trim aliases from
ListAggexpression subtree in order to fix a discrepancy between single-pass and fixed-point analyzers.It is a safe change since it would otherwise be removed in
CleanupAliases.Why are the changes needed?
To fix a dual-run issue.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added + existing tests.
Was this patch authored or co-authored using generative AI tooling?
Yes.