[SPARK-55747][SQL] Fix NPE when accessing elements from an array that is null#54546
Closed
stevomitric wants to merge 3 commits intoapache:masterfrom
Closed
[SPARK-55747][SQL] Fix NPE when accessing elements from an array that is null#54546stevomitric wants to merge 3 commits intoapache:masterfrom
stevomitric wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
cc @cloud-fan to PTAL |
stevomitric
changed the title
LuciferYang
reviewed
Feb 27, 2026
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: YangJie <yangjie01@baidu.com>
cloud-fan
approved these changes
Feb 27, 2026
cloud-fan
reviewed
Feb 28, 2026
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala
Outdated
Show resolved
Hide resolved
Contributor
|
the OOM issue is unrelated, thanks, merging to master/4.1! |
cloud-fan
added a commit
that referenced
this pull request
Mar 1, 2026
… is null ### What changes were proposed in this pull request? The `GetArrayItem` expression incorrectly computed `nullable = false` when indexing into arrays with `containsNull = false` (e.g., from split()), even when the array itself could be null. This caused codegen to skip null checks, leading to NPE on `array.numElements()` during bounds checking. ### Why are the changes needed? To resolve NPE within spark engine. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tests in this PR. ### Was this patch authored or co-authored using generative AI tooling? No Closes #54546 from stevomitric/stevomitric/fix-npe-codegen. Lead-authored-by: Wenchen Fan <cloud0fan@gmail.com> Co-authored-by: Stevo Mitric <stevo.mitric@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit c0e367a) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
GetArrayItemexpression incorrectly computednullable = falsewhen indexing into arrays withcontainsNull = false(e.g., from split()), even when the array itself could be null. This caused codegen to skip null checks, leading to NPE onarray.numElements()during bounds checking.Why are the changes needed?
To resolve NPE within spark engine.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tests in this PR.
Was this patch authored or co-authored using generative AI tooling?
No