Skip to content

[SPARK-55719][SQL] Remove deprecation warning for spark.sql.hive.convertCTAS#54521

Open
allisonwang-db wants to merge 1 commit intoapache:masterfrom
allisonwang-db:remove-convertctas-deprecation
Open

[SPARK-55719][SQL] Remove deprecation warning for spark.sql.hive.convertCTAS#54521
allisonwang-db wants to merge 1 commit intoapache:masterfrom
allisonwang-db:remove-convertctas-deprecation

Conversation

@allisonwang-db
Copy link
Contributor

What changes were proposed in this pull request?

This PR removes the spark.sql.hive.convertCTAS configuration from deprecatedSQLConfigs in
SQLConf.scala.

Why are the changes needed?

The spark.sql.hive.convertCTAS configuration is actually useful and continues to serve a purpose in the codebase. Removing the deprecation warning prevents unnecessary confusion for users who rely on this configuration.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

Was this patch authored or co-authored using generative AI tooling?

No

@allisonwang-db
Copy link
Contributor Author

cc @cloud-fan

Copy link
Member

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially was wondering, why not just use the suggestion (LEGACY_CREATE_HIVE_TABLE_BY_DEFAULT_KEY), but that flag seems its a bit broader than CONVERT_CTAS?

Maybe could clarify the doc for CONVERT_CTAS to not lose this correlation, but otherwise make sense to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants