[SPARK-55708][SQL] TransformingEncoder with primitive inside OptionEncoder#54506
Open
eejbyfeldt wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-55708][SQL] TransformingEncoder with primitive inside OptionEncoder#54506eejbyfeldt wants to merge 1 commit intoapache:masterfrom
eejbyfeldt wants to merge 1 commit intoapache:masterfrom
Conversation
Fix bug when a transformingEncoder from primitive is used inside an OptionEncoder.
Contributor
Author
|
@hvanhovell @chris-twiner here is another issue I ran into trying to move to the AgnosticEncoders. Would be great if someone could have review. |
eejbyfeldt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make it possible to use TransformingEncoder from a primitive type and have that inside an OptionEncoder.
Supports for primitives using TransformingEncoder was initially improved in #51313 but it was missed that it did not work inside an OptionEncoder. The fix here also cleans up how javaClassToPrimitiveType is computed, it was missed that the values in typeJavaMapping are not unique and the previous code would assign wrong types for some classes.
Why are the changes needed?
To make the AgnosticEncoders as flexible as Expression based encoders were, this will allow libraries providing custom encoders to move to Spark 4.0.0 and beyond.
Does this PR introduce any user-facing change?
Yes, libraries trying to derive custom encoders with have more flexibility.
How was this patch tested?
Existing and new unittests.
Was this patch authored or co-authored using generative AI tooling?
No.