Skip to content

SOLR-16398: Add V2 JAX-RS APIs for GET replication restore status and commits. - #5217

Open
jaykay12 wants to merge 12 commits into
apache:mainfrom
jaykay12:SOLR-16398-replication-phase2
Open

jaykay12 wants to merge 12 commits into
apache:mainfrom
jaykay12:SOLR-16398-replication-phase2

Conversation

@jaykay12

@jaykay12 jaykay12 commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

https://issues.apache.org/jira/browse/SOLR-16398

Description

Add V2 JAX-RS APIs for GET replication restore status and commits.

Solution

Used Cursor for approach & self-code reviews. Code is fully vetted by Jalaz Kumar.

Tests

  • CoreReplicationAPITest
  • FetchCommitsAPITest
  • FetchRestoreStatusAPITest

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide
  • I have added a changelog entry for my change

@github-actions github-actions Bot added documentation Improvements or additions to documentation tests cat:api labels Oct 24, 2026

@jaykay12 jaykay12 left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review ✅
precommit ✅

local testing [pending][will do after first round of review]

@epugh @gerlowskija Can you trigger github copilot review to start with?


@GET
@CoreApiParameters
@Path("/restore/status")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although V2 api sheet suggests GET /restore for this, but imo, GET /restore/status is more comprehensive.

@nick-boss-tech

Copy link
Copy Markdown
Contributor

Quick Review:
The v1 commits handler now converts commit entries into objects, changing the existing JSON response for callers requesting json.nl=flat or other array styles.
Preserve plain NamedList entries in the v1 adapter and add a serialization regression test. The ordinary v2 paths otherwise look coherent.

AI-generated. Static review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:api documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants